Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve prettier troubleshooting doc: add npx tsc. #23867

Merged
merged 1 commit into from
May 9, 2023
Merged

Improve prettier troubleshooting doc: add npx tsc. #23867

merged 1 commit into from
May 9, 2023

Conversation

konrad-jamrozik
Copy link

@konrad-jamrozik konrad-jamrozik commented May 9, 2023 •
edited
Loading

This PR is made by the Azure SDK Engineering System team. This PR is making improvements to documentation at https://aka.ms/ci-fix

This doc update is necessary as a result of the following update:

More context provided in this internal Teams chat

@openapi-workflow-bot
Copy link

Hi, @konrad-jamrozik Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand] 
    Validation passes for ServiceAPIReadinessTest.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2023 •
    edited
    Loading

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @openapi-pipeline-app
    Copy link

    Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

    @konrad-jamrozik konrad-jamrozik changed the title Improve prettier instructions: add npx tsc. Improve aka.ms/ci-fix prettier instructions: add npx tsc. May 9, 2023
    @konrad-jamrozik konrad-jamrozik changed the title Improve aka.ms/ci-fix prettier instructions: add npx tsc. Improve prettier troubleshooting doc: add npx tsc. May 9, 2023
    @konrad-jamrozik
    Copy link
    Author

    @weshaggard @mikeharder Looks like running npx tsc is causing updates to npm dependencies that want to get commited to the repo, per this Teams comment. Not sure what is the best way forward here.

    @weshaggard weshaggard merged commit 69df3c5 into main May 9, 2023
    @weshaggard weshaggard deleted the users/kojamroz/fix_tsc branch May 9, 2023 22:01
    @konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label May 20, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weshaggard weshaggard weshaggard approved these changes

    @mikeharder mikeharder Awaiting requested review from mikeharder

    Assignees

    @josefree josefree

    Labels
    Central-EngSys This issue is owned by the Engineering System team. resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @konrad-jamrozik @weshaggard @josefree @AzureRestAPISpecReview